FrankChen021 commented on PR #20351: URL: https://github.com/apache/druid/pull/20351#issuecomment-5674620478
This is an automated review by Codex GPT-5.6 Luna(Max).\n\nROUND_1 result: incompatible; not approved. The exact-head rollup is FAILURE (27 CheckRuns: 5 SUCCESS, 20 FAILURE, 1 SKIPPED, 1 NEUTRAL; 0 StatusContexts). All failed build paths converge on the generated Druid SQL parser: JavaCC 3.2.1 runs JavaCC 7.0.13 and javac under JDK 25 reports six definite-assignment errors in DruidSqlParserImpl.java (startNum/endNum/reluctant in PatternFactor and e in AtomicRowExpression). I reproduced generation in the isolated worktree; the 2.4 baseline generates the corresponding parser without these errors. The failures are deterministic and PR-caused, so no rerun was justified.\n\nThe change is build-only in pom.xml, but the cumulative generator change is not SAFE for Druid SQL compilation. A speculative grammar repair would expand this dependency-only PR and alter generated-parser behavior; no bounded safe repair was validated. No approval or push was made. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
