FrankChen021 commented on code in PR #20314:
URL: https://github.com/apache/druid/pull/20314#discussion_r4036793467
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerConfig.java:
##########
@@ -181,6 +195,19 @@ public boolean isAuthorizeTableVisibility()
}
/**
+ * See {@link #maxPlanningTimeMs}. Returns {@link
#PLANNING_TIME_NOT_LIMITED} when planning time is unbounded.
+ */
+ public long getMaxPlanningTimeMs()
+ {
+ return maxPlanningTimeMs;
+ }
+
+ /**
+ * Whether a planning timeout is configured.
+ */
+ public boolean isPlanningTimeLimited()
+ {
+ return maxPlanningTimeMs > PLANNING_TIME_NOT_LIMITED;
Review Comment:
[P1] Close the new planning-timeout method
**Finding:** The merged source ends `isPlanningTimeLimited()` after its
return statement without a closing `}`. The following existing `* Whether
catalog DDL...` text is therefore outside a Javadoc comment, so
`PlannerConfig.java` cannot be parsed or compiled and the SQL module build
fails.
**Suggestion:** Restore the method closing brace and the opening Javadoc
delimiter for the following `isEnableCatalogDdl()` method in the merge result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
