FrankChen021 commented on code in PR #19392: URL: https://github.com/apache/druid/pull/19392#discussion_r4058887341
########## docs/operations/metrics.md: ########## @@ -428,14 +428,14 @@ These metrics are emitted by the Druid Coordinator in every run of the correspon |`segment/loadQueue/count`|Number of segments to load.|`server`|Varies| |`segment/loading/rateKbps`|Current rate of segment loading on a server in kbps (1000 bits per second). The rate is calculated as a moving average over the last 10 GiB or more of successful segment loads on that server.|`server`|Varies| |`segment/dropQueue/count`|Number of segments to drop.|`server`|Varies| -|`segment/loadQueue/assigned`|Number of segments assigned for load or drop to the load queue of a server.|`dataSource`, `server`|Varies| -|`segment/loadQueue/success`|Number of segment assignments that completed successfully.|`dataSource`, `server`|Varies| -|`segment/loadQueue/failed`|Number of segment assignments that failed to complete.|`dataSource`, `server`|0| -|`segment/loadQueue/cancelled`|Number of segment assignments that were canceled before completion.|`dataSource`, `server`|Varies| +|`segment/loadQueue/assigned`|Number of segments assigned for load or drop to the load queue of a server.|`dataSource`, `description`|Varies| Review Comment: [P2] Retain the emitted server dimension The four load-queue metrics still carry `server`. `HttpLoadQueuePeon.incrementStat` creates each row with `dataSource` and `description`, then `DruidCoordinator.CollectLoadQueueStats` calls `createRowKeyForServer`, which adds `Dimension.SERVER` before the row is emitted. This applies to `assigned`, `success`, `failed`, and `cancelled` through the shared `RequestStatus`/`incrementStat` path. Please document all three dimensions as `dataSource`, `server`, and `description`; the corresponding StatsD mappings should also retain `server` if they are intended to preserve every emitted dimension. The separate `segment/unneededEternityTombstone/count` update to `dataSource` is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
