FrankChen021 commented on PR #20398: URL: https://github.com/apache/druid/pull/20398#issuecomment-5771448043
Compatibility correction for exact head `f2a32b8ce7fd5d8d36c2ba0349cafd3866435661`: **INCOMPATIBLE**. The complete PR diff is one line: `com.github.luben:zstd-jni` `1.5.7-11` → `1.5.7-17`. Upstream publishes every release `1.5.7-12` through `1.5.7-17`; `1.5.7-12` is the last release with pre-1.0 v0.4–v0.7 legacy-frame decoding, and `1.5.7-13` removes the legacy native sources and fixtures. A smoke test with upstream `xml_v04.zst` decodes 5,345,280 bytes on `1.5.7-11` and `1.5.7-12`, but fails with `Unknown frame descriptor` on every release from `1.5.7-13` through `1.5.7-17`. Druid’s documented `.zst` batch-ingestion path in [`CompressionUtils`](https://github.com/apache/druid/blob/f2a32b8ce7fd5d8d36c2ba0349cafd3866435661/processing/src/main/java/org/apache/druid/utils/CompressionUtils.java#L803-L810) constructs Commons Compress `ZstdCompressorInputStream`, whose constructor creates `com.github.luben.zstd.ZstdInputStream`. The dependency-only bump would therefore regress externally supplied legacy `.zst` batch ingestion. This supersedes the prior SAFE approval (review `5273889567`); the earlier closures of [#20110](https://github.com/apache/druid/pull/20110) and [#20228](https://github.com/apache/druid/pull/20228) establish the same compatibility issue. Closing without merge. A safe repair requires an explicit compatibility/product decision, a legacy-capable build or version cap, or a migration plan; that is beyond a bounded dependency-only repair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
