FrankChen021 commented on code in PR #20477:
URL: https://github.com/apache/druid/pull/20477#discussion_r4171412322


##########
hooks/install-hooks.sh:
##########


Review Comment:
   I didn't run this script for long, and I remember initially we didn't need 
to provide this argument. I checked the change history, #12300 introduced this 
requirement. Current document also does not mention this argument either.
   
   However, I think this DRUID_ROOT can be inferred from running dir, and if 
it's not able to infer, then we can exit the script with the usage help text



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to