nanjeshramesh opened a new pull request, #20530:
URL: https://github.com/apache/druid/pull/20530
Fixes #16894.
### Description
#16886 removed the query ID verification from MSQ workers because, until
Druid 30, the query IDs of individual stages could be random UUIDs instead of
the real query ID (fixed in #16168). A newer worker talking to a controller
from one of those versions would then fail the check. The issue asks for the
check to come back once Druid 34 is released, and the latest stable release is
now 38, so this restores it.
`WorkerImpl.KernelHolders` checks again that the query ID of a stage matches
the worker's query ID when a kernel is added, finished, removed or looked up,
using the same `verifyQueryId` helper as before #16886. The note about the old
bug that #16886 added to the `StageId` Javadoc is removed.
This is the inverse of #16886 applied to the current file location, so the
check is exactly what it was before.
##### Key changed/added classes in this PR
* `WorkerImpl`
* `StageId`
<hr>
I did not add a new test. The check runs on every stage of the existing end
to end tests, and `WorkerImplTest`, `DartWorkerRunnerTest`, `RunWorkOrderTest`,
`MSQSelectTest`, `MSQInsertTest`, `MSQFaultsTest` and `MSQWindowTest` all pass
with it (866 tests), with checkstyle clean.
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
