FrankChen021 commented on code in PR #20559:
URL: https://github.com/apache/druid/pull/20559#discussion_r4271548810
##########
extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java:
##########
@@ -175,6 +184,19 @@ protected void logLostMessagesStatus()
currentSegmentMetadataLost -
previousSegmentMetadataLost.getAndSet(currentSegmentMetadataLost);
long deltaInvalidLost = currentInvalidLost -
previousInvalidLost.getAndSet(currentInvalidLost);
+ long currentMetricSampled = metricSampled.get();
+ long deltaMetricSampled = currentMetricSampled -
previousMetricSampled.getAndSet(currentMetricSampled);
+
+ if (deltaMetricSampled > 0) {
Review Comment:
Confirmed resolved in the current head. `previousMetricEmitted` now advances
on every status check, so an interval with emitted-but-not-sampled metrics is
not included again in a later sampling summary. The added
`testSamplingSummaryWindowAdvancesWhenNothingSampled` covers this case; I
reviewed 5 of 5 changed files and found no further actionable issue.
---
This is an automated review by Codex GPT-5.6-Luna(max)
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
