kyhtsang commented on code in PR #20616:
URL: https://github.com/apache/druid/pull/20616#discussion_r4298494144
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/BasicAuthUtils.java:
##########
@@ -237,6 +243,24 @@ public static byte[]
serializeAuthorizerRoleMap(ObjectMapper objectMapper, Map<S
}
}
+ public static boolean isDefaultSuperuserName(String name)
+ {
+ return ADMIN_NAME.equals(name) || INTERNAL_USER_NAME.equals(name);
Review Comment:
This assigns superuser to users named "admin" but that means it can only be
assigned to that user
Should we consider adding a resource type / name / action that represents
tenants so * or particular tenant access can be represented in basic auth?
Maybe a future thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
