FrankChen021 commented on PR #20623: URL: https://github.com/apache/druid/pull/20623#issuecomment-6245414436
ROUND_1 compatibility decision: this PR is incompatible with Druid and is being closed. The complete published plugin path reviewed is JavaCC Maven plugin 2.4 -> 2.4.1 -> 2.5 -> 2.6. The upgrade changes the bundled JavaCC engine from 4.0 to 5.0 and changes generated parser token/error behavior. Druid's generated SQL parser depends on those ParseException token sequences and token images. On the exact head 4acfdeb78449573a92f60411c80e97b639207500, four completed unit-test shards fail deterministically with PR-caused parser regressions: CalciteInsertDmlTest, SqlQueryPlusTest/SqlResourceTest, MSQSelectTest, and reserved-keyword/sealed-DDL parser tests. The observed invalid-SQL messages and token handling change across Druid's Calcite, HTTP/JDBC, and MSQ paths. This is runtime incompatibility, not infrastructure flakiness; rerunning the unchanged head cannot make the upgrade safe. No bounded source repair was authorized for this dependency-only PR. The PR is closed as incompatible after this evidence was posted. No merge was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
