vogievetsky commented on code in PR #20621:
URL: https://github.com/apache/druid/pull/20621#discussion_r4305832247
##########
web-console/src/editor-completions/sql-completions.ts:
##########
@@ -100,6 +104,9 @@ const SQL_KEYWORD_FOLLOW_SUGGESTIONS: Record<string,
string[]> = {
GROUPING: ['SETS'],
FETCH: ['FIRST', 'NEXT'],
FIRST: ['ROW', 'ROWS'],
+ ASC: ['NULLS'],
+ DESC: ['NULLS'],
+ NULLS: ['FIRST', 'LAST'],
Review Comment:
Good catch, fixed in 3790acd20d. Follow-up keyword suggestions can now also
be keyed by the two keywords before the cursor
(`SQL_KEYWORD_PAIR_FOLLOW_SUGGESTIONS`), which take precedence over the single
keyword, so `NULLS FIRST` suggests nothing while `FETCH FIRST` still suggests
`ROW` / `ROWS`. The test now covers both (plus `nulls` / `first` split across
lines in lower case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
