Nimish2098 commented on code in PR #20626:
URL: https://github.com/apache/druid/pull/20626#discussion_r4321546293
##########
server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorTest.java:
##########
@@ -189,10 +189,10 @@ public void testSimpleIngestion() throws Exception
SegmentGenerationMetrics segmentGenerationMetrics = tester.getMetrics();
Assertions.assertEquals(2, segmentGenerationMetrics.numPersists());
Assertions.assertEquals(3, segmentGenerationMetrics.rowOutput());
- Assertions.assertTrue(segmentGenerationMetrics.persistTimeMillis() > 0);
+ Assertions.assertTrue(segmentGenerationMetrics.persistTimeMillis() >= 0);
Review Comment:
Thanks for the pointers. I’ve pushed the nanosecond-based change: persist
and merge time are stored in nanoseconds with the millisecond values derived
from them, the appenderators record elapsed nanoseconds, the monitor subtracts
nanosecond totals before converting, and the test asserts positive nanosecond
timing and the millisecond conversion. I also added Stopwatch.nanosElapsed()
for this. I’ve updated the title and description. Happy to adjust anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
