capistrant commented on code in PR #20617:
URL: https://github.com/apache/druid/pull/20617#discussion_r4330593332
##########
server/src/main/java/org/apache/druid/segment/loading/PartialSegmentMetadataCacheEntry.java:
##########
@@ -1192,6 +1204,18 @@ private Optional<Segment>
buildSegmentWithExtraClose(@Nullable Closeable extraOn
);
}
index = queryableIndex;
+ if (ruleHeldOnly) {
+ // Snapshot the selection (empty when no rule is applied). It names
physical bundles, since the cache manager
+ // resolves it when applying the rule, while the planner asks by
logical name, so resolve each requested name
+ // the same way the bundle acquirer does: on a legacy root-only
segment every name maps to the root bundle.
+ final Set<String> selected = ruleSelectedBundleNames;
+ final PartialSegmentFileMapperV10 mapper = fileMapper;
+ servableBundles = bundleName -> selected.contains(
Review Comment:
this seems to be describing an existing issue that would impact the existing
PARTIAL acquire mode on master, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
