FrankChen021 commented on code in PR #20694:
URL: https://github.com/apache/druid/pull/20694#discussion_r4367164544
##########
.github/scripts/auto-add-milestone.sh:
##########
@@ -19,13 +19,18 @@ set -e
get_milestone_number() {
local milestone_title="$1"
- local number=$(gh api "repos/$REPOSITORY/milestones" --jq ".[] |
select(.title==\"$milestone_title\") | .number")
+ local number=$(gh api "repos/$REPOSITORY/milestones?state=all&per_page=100"
--paginate --jq ".[] | select(.title==\"$milestone_title\") | .number")
Review Comment:
Confirmed the original P2 is fixed at head e84b4d9: `number` is declared
separately and the paginated lookup now returns on `gh api` failure, so an API
error cannot fall through to milestone creation. I reviewed all 3 changed files
and found no additional actionable issues.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
