FrankChen021 commented on code in PR #20722:
URL: https://github.com/apache/druid/pull/20722#discussion_r4367540966
##########
sql/src/test/java/org/apache/druid/sql/calcite/expression/LeastExpressionTest.java:
##########
@@ -268,11 +277,11 @@ private void testExpression(
final Object expectedResult
)
{
- testHelper.testExpressionString(target.calciteOperator(), exprs,
expectedExpression, expectedResult);
+ testHelper.testExpression(target.calciteOperator(), exprs,
expectedExpression, expectedResult);
}
- private DruidExpression buildExpectedExpression(Object... args)
+ private DruidExpression buildExpectedExpression(ColumnType type, Object...
args)
Review Comment:
As we already touch this function, I think we can rename this one to
`expectedLeastFunctionCall` to make current test case better to understand.
This renaming suggestion also applies to other test case files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
