amaechler opened a new pull request, #20726:
URL: https://github.com/apache/druid/pull/20726
### Description
`TaskCountStatsMonitor` used one metric builder for every row of a
`task/*/count` metric. The builder keeps every dimension it is given, so each
row also reported dimensions left over from earlier rows. For example, a
`compact` task row could report a Kafka supervisor's `supervisorId`, and a row
with no dimensions reported the previous row's `dataSource` and `taskType`.
This PR creates a new builder for each row. A row with no dimensions is now
emitted without any. The leak goes back to #18032, and #18920 made it more
visible by adding `supervisorId`.
#### Release note
Fixed Overlord `task/*/count` metrics reporting dimensions from other rows,
such as a `supervisorId` on non-streaming tasks.
<hr>
##### Key changed/added classes in this PR
* `TaskCountStatsMonitor`
<hr>
This PR has:
- [x] been self-reviewed.
- [x] a release note entry in the PR description.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
