TimurRakhmatullin86 commented on PR #20424: URL: https://github.com/apache/druid/pull/20424#issuecomment-6446119706
@kgyrtkirk no specific production incident — this came from a systematic review of catch-InterruptedException blocks. The practical risk is that swallowing the interrupt flag can prevent thread-pool shutdown from completing on time (the calling thread no longer knows it was interrupted, so it may loop or block again instead of propagating the cancellation). In Druid's case, long-running ingestion or query threads are the most likely to be affected. You are right that a static analysis check would be the better long-term fix. SpotBugs has `SR_LOST_INTERRUPT` (experimental) and Error Prone has `InterruptedExceptionSwallowed` — either could be enabled in the build to catch future regressions. I will rebase to resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
