FrankChen021 commented on code in PR #20734:
URL: https://github.com/apache/druid/pull/20734#discussion_r4401042554
##########
.github/workflows/ci.yml:
##########
@@ -62,3 +62,22 @@ jobs:
script: .github/scripts/run_unit-tests ${{ matrix.args }}
-Dmaven.test.failure.ignore=true
key: ${{ matrix.name }}
artifact_prefix: "unit-test-reports-jdk25"
+
+ static-checks-maven:
Review Comment:
[P2] Keep RAT coverage for benchmark-only changes
**Finding:** Moving `static-checks-maven` here makes it depend on the
caller's path filters. The current caller ignores Markdown-only changes at
`.github/workflows/unit-and-integration-tests-unified.yml:42-43`, while
`.github/scripts/packaging-check.sh:24` and `:27` exclude `benchmarks` from
both RAT builds, so a benchmark-only Markdown change can bypass RAT entirely.
**Suggestion:** Keep the repository-wide RAT invocation in an
always-triggered workflow or make the always-on packaging/RAT job include
`benchmarks`.
##########
.github/scripts/pull_docker_images:
##########
@@ -0,0 +1,31 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Pulls every Docker image declared via DruidCI.cacheDockerImage("<image>") in
Java sources.
+
+set -eu
+
+CALL='DruidCI\.cacheDockerImage\('
+
+if git grep -nE "$CALL" -- '*.java' | grep -vE "$CALL\"[^\"]+\"\)"; then
+ echo "::error ::DruidCI.cacheDockerImage must be called with a string
literal"
+ exit 1
+fi
+
+for image in $(git grep -hoE "$CALL\"[^\"]+\"" -- '*.java' | grep -oE
'"[^"]+"' | tr -d '"' | sort -u); do
Review Comment:
[P3] Include the Redpanda image in pre-pulls
**Finding:** This extractor only sees literals wrapped in
`DruidCI.cacheDockerImage`, but
`embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/SchemaRegistryResource.java:51`
still defines the Redpanda image directly and constructs it at line 67.
`StreamIndexDataFormatsTestBase:128` uses this resource in ordinary unit tests,
so the new pre-pull list omits an image that is fetched on demand during the
matrix.
**Suggestion:** Wrap the Redpanda image literal with
`DruidCI.cacheDockerImage` so the source-derived list includes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
