vogievetsky opened a new pull request, #20777:
URL: https://github.com/apache/druid/pull/20777
## Summary
Three small workbench fixes.
**1. Column header menu labels the ASC copy item as DESC.** When the query
can't be parsed, the column header menu offers to copy `ORDER BY` expressions.
The ASC item's label and its "copied" toast showed the DESC text (the clipboard
did get the ASC text):
```diff
const descOrderByPretty = prettyPrintSql(descOrderBy);
-const ascOrderByPretty = prettyPrintSql(descOrderBy);
+const ascOrderByPretty = prettyPrintSql(ascOrderBy);
```
**2. Mod+Enter adds a blank line to the query.** Mod+Enter / Mod+Shift+Enter
are the global run / preview hotkeys, but CodeMirror's `defaultKeymap` also
binds `Mod-Enter` to `insertBlankLine`, so each run added a line to the query.
The editor now claims both keys at `Prec.highest`. It only closes the
completion popup, and the event still bubbles up to the run hotkey:
```diff
FlexibleQueryInput extensions
+ Prec.highest(keymap: Mod-Enter, Mod-Shift-Enter → closeCompletion,
handled)
subQueryCompartment
```
**3. BigInt cells in numeric columns don't get digit grouping.** Results are
parsed with JSONBig, so integers with 16+ digits come back as `bigint`. The
numeric cell renderer checked `typeof value === 'number'` and fell back to
`String(value)` for them. It now uses `isNumberLike`, and `formatNumber`
already accepts `bigint`.
## Evidence
- **BigInt cells:**
**Before:** `String(12345678901234567n)` → `12345678901234567`
**After:** `formatNumber(12345678901234567n)` → `12,345,678,901,234,567`
- **Checks:** `npm run test-base` (eslint, sasslint, prettier, jest: 856
tests) and `tsc --noEmit` pass. No new tests were added for these three fixes.
## Merge Danger
**Door:** two-way
**Blast Radius:** web-console
All changes are in the workbench. The keymap change affects only Mod+Enter
and Mod+Shift+Enter inside the query editor.
#### Release note
Fixes three web console workbench bugs: Mod+Enter no longer adds a blank
line to the query, very large integers in result tables now get digit grouping,
and the column menu's ASC copy item no longer shows the DESC label.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
