FrankChen021 opened a new pull request, #20781:
URL: https://github.com/apache/druid/pull/20781

   Fixes #20750.
   
   ### Description
   
   A standalone Overlord decides whether it is embedded in a Coordinator by 
reading `druid.coordinator.asOverlord.enabled`. When that Coordinator-only 
property reaches the Overlord, for example because both services share one 
`runtime.properties`, the Overlord never starts the segment metadata cache. 
With `druid.manager.segments.useIncrementalCache=always`, every segment write 
then hangs.
   
   This PR:
   - Binds a new `OverlordMode` enum (`STANDALONE` / `EMBEDDED_IN_COORDINATOR`) 
in `CliOverlord`, taken from how the process was started. `DruidOverlord` and 
`OverlordCompactionScheduler` use it instead of 
`CoordinatorOverlordServiceConfig`.
   - Removes `CoordinatorOverlordServiceConfig` and the unused 
`druid.coordinator.asOverlord.overlordService` property from the docs and 
example configs.
   
   #### Release note
   
   A standalone Overlord now ignores `druid.coordinator.asOverlord.enabled`. 
`druid.coordinator.asOverlord.overlordService` is no longer used and can be 
removed.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added unit tests or modified existing tests to cover new code paths.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to