leventov commented on a change in pull request #7306: Reconcile terminology and
method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r274546791
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -48,21 +49,21 @@
{
public static final String CONFIG_KEY = "coordinator.config";
- private final long millisToWaitBeforeDeleting;
+ private final long
millisLagSinceCoordinatorBecomesLeaderBeforeCanMarkAsUnusedOvershadowedSegments;
Review comment:
I don't like the loss of meaning or even confusion in the "initial"
adjective. Also, other configuration parameter names in this class don't drop
the "Segments" part, except for `replicantLifetime` and
`replicationThrottleLimit` which are bad names anyway. I also wanted to keep
the "MarkAsUnused" part together, because it appears in different places in the
code. What about `leadingTimeMillisBeforeCanMarkAsUnusedOvershadowedSegments`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
