drcrallen edited a comment on issue #7509: Fix too many dentry cache slab objs#7508. URL: https://github.com/apache/incubator-druid/pull/7509#issuecomment-484903798 There's another hidden FS bug here: ``` synchronized (files) { if (closed) { return; } ... ``` If two methods call this, and the first one that finishes causes the JVM to be shut down, then the other one may never finish and actually do the delete. It is at the author's discretion if they want to keep the scope of this PR to just #7508 or to fix up `LimitedTemporaryStorage::close`` in general If the author wishes to keep the scope limited, then I'm 👍 once the `isEmpty` change is made
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
