AlexanderSaydakov edited a comment on issue #7486: regression: quantilesDoublesSketch returns null instead of empty array URL: https://github.com/apache/incubator-druid/issues/7486#issuecomment-485008357 In your example query you wanted four quantile values for ranks 0.5, 0.9, 0.95 and 0.99. How would you process the result? What if it is an empty array, not an array with four values you would expect? This is about DoublesSketchToQuantilesPostAggregator.java Currently it just returns the result from the sketch like so: return sketch.getQuantiles(fractions); We might change that to something like this: double[] quantiles = sketch.getQuantiles(fractions); if (quantiles == null) quantiles = new double[0]; return quantiles; And I think we have a bigger problem in DoublesSketchToHistogramPostAggregator.java It is going to throw a null pointer exception. We may also want to add more post-aggs to get rank of a given value and get CDF.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
