clintropolis commented on a change in pull request #7658: Fix broken links in docs, add broken link checker. URL: https://github.com/apache/incubator-druid/pull/7658#discussion_r284130416
########## File path: docs/_bin/deploy-docs.sh ########## @@ -88,6 +88,9 @@ remote=$(git -C "$druid" config --local --get "remote.$origin.url") git clone -q --depth 1 --branch $branch $remote "$src" if [ -n "$opt_docs" ] ; then + # Check for broken links + "$src/docs/_bin/broken-link-check.py" "$src/docs/content" "$src/docs/_redirects.json" Review comment: As far as I could tell, this script doesn't modify anything and just prints out the broken links/redirects, what is the purpose of calling it here? Should we be catching the exit code and have it cause a failure of some sort if it has non-zero exit code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
