leventov commented on a change in pull request #7681: Add checkstyle for "Local
variable names shouldn't start with capital"
URL: https://github.com/apache/incubator-druid/pull/7681#discussion_r285696714
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/StringUtils.java
##########
@@ -40,6 +40,7 @@
public class StringUtils
{
public static final byte[] EMPTY_BYTES = new byte[0];
+ public static final String LINE_SEPARATOR = System.lineSeparator();
Review comment:
Since there is a direct method in `System` (rather than getProperty(...))
there is no point in storing it in a constant. Please use directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
