himanshug commented on a change in pull request #7716: AggregatorUtil should cache parsed expression to avoid memory problem (OOM/FGC) when Expression is used in metricsSpec URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r286191367
########## File path: core/src/main/java/org/apache/druid/math/expr/Parser.java ########## @@ -75,6 +75,9 @@ public static Expr parse(String in, ExprMacroTable macroTable) @VisibleForTesting static Expr parse(String in, ExprMacroTable macroTable, boolean withFlatten) { + if (log.isDebugEnabled()) { Review comment: also, not sure if you really need this log at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org