sashidhar edited a comment on issue #7609: Local variable names shouldn't start with capital URL: https://github.com/apache/incubator-druid/issues/7609#issuecomment-494883301 @leventov 1. This is the match pattern I'm currently using for Local Variable names `'^[a-z_](_?[a-zA-Z0-9_]+)*$'`considering variables starting with and ending with underscores as well. Let me know if this is fine. 2. There are several occurrences of variables which are not constants (non final) and have variables all capitalized for instance, Pattern DOT_OR_WHITESPACE = Pattern.compile("[\\s]+|[.]+"); etc. I'm changing these to lower case. Is that fine ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
