jihoonson commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-495331651 > Note that I unblocked #7425 only on the condition that people agree with the proposed approach and it's being implemented immediately: #7425 (comment). If I knew that new round of debate will start, I wouldn't unblock that PR and insisted on completely resolving that question before merging. @leventov thank you for additional context. I didn't notice this before. This sounds like Both https://github.com/apache/incubator-druid/pull/7425 and https://github.com/apache/incubator-druid/pull/7595 are supposed to be done in a single PR, but they are separate for the sake of convenience of the author and reviewers. And I like to avoid two potential problems in https://github.com/apache/incubator-druid/pull/7425, i.e., slow API performance and internal API mismatch between versions. So, I think it makes sense to add this to 0.15.0 as long as https://github.com/apache/incubator-druid/pull/7595 won't take long time. > So what about the following: > > - Immutable, but extensible DataSegment. > - Immutable SegmentWithOvershadowedStatus which extends DataSegment (note: they also have different JSON representations). > - Although immutable, both are decidedly containers, not "data classes". They both prohibit equals() and hashCode() as described here. Your suggestion sounds good to me. > Memory and concurrency (see #7595). https://github.com/apache/incubator-druid/pull/7595 looks about eager computation of overshadowed segments rather than mutable segments. Would you tell me more how the mutable segment helps concurrency?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
