leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-495738096 @jihoonson the concurrency discussion started here: https://github.com/apache/incubator-druid/pull/7595#discussion_r282159218. @jon-wei argued that type of concurrent inconsistency is OK, but I'm not sure and don't want to verify that. That issue can be worked around relatively easily by creating an object `DataSourcesAndOvershadowedSegments` inside `SQLSegmentMetadataManager` and update a field with it atomically, rather than having two separate fields `dataSources` and `overshadowedSegments`, but this problem naturally goes away itself when `SQLSegmentMetadataManager` will store `SegmentWithOvershadowedStatus` objects in `dataSources` in the first place.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
