jon-wei commented on a change in pull request #7588: multi-value string column 
support for expressions
URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r290471916
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
 ##########
 @@ -118,11 +182,41 @@ public ExprEval eval(ObjectBinding bindings)
   }
 }
 
+class LongArrayExpr extends ConstantArrayExpr
+{
+  private final Long[] value;
 
 Review comment:
   If `druid.generic.useDefaultValueForNull` is false, it's possible to have 
null longs and doubles, so I think it makes sense to allow that for arrays as 
well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to