jon-wei commented on a change in pull request #8019: multi-value string
expression transformation fix
URL: https://github.com/apache/incubator-druid/pull/8019#discussion_r300193230
##########
File path: core/src/main/java/org/apache/druid/math/expr/Parser.java
##########
@@ -171,13 +171,9 @@ public static Expr applyUnappliedIdentifiers(Expr expr,
Expr.BindingDetails bind
return expr;
}
List<String> unapplied = toApply.stream()
- .filter(x ->
bindingDetails.getFreeVariables().contains(x))
+ .filter(x ->
bindingDetails.getRequiredColumnsList().contains(x))
Review comment:
Suggest using `getRequiredColumns` here, since `contains` should be cheaper
on the Set vs ArrayList if there are lots of columns (and skip the ArrayList
creation too)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
