himanshug commented on a change in pull request #8086: add Class.getCanonicalName to forbidden-api URL: https://github.com/apache/incubator-druid/pull/8086#discussion_r304047609
########## File path: codestyle/druid-forbidden-apis.txt ########## @@ -34,6 +34,7 @@ java.util.Random#<init>() @ Use ThreadLocalRandom.current() or the constructor w java.lang.Math#random() @ Use ThreadLocalRandom.current() java.util.regex.Pattern#matches(java.lang.String,java.lang.CharSequence) @ Use String.startsWith(), endsWith(), contains(), or compile and cache a Pattern explicitly org.apache.commons.io.FileUtils#getTempDirectory() @ Use org.junit.rules.TemporaryFolder for tests instead +java.lang.Class#getCanonicalName() @Class.getCanonicalName can return null for anonymous types, use Class.getName instead. Review comment: on other lines I see a space between '@' and message start , it might or might not be important but we could add that space just to be consistent . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
