himanshug commented on issue #6743: IncrementalIndex generally overestimates theta sketch size URL: https://github.com/apache/incubator-druid/issues/6743#issuecomment-512351575 @gianm thanks, will write a proposal today . I do plan to implement it (or at least some parts of the proposal to validate my own thinking) > I'd prefer a special return value from aggregate rather than throwing an exception, for two reasons: exceptions are expensive to generate, and also that this situation is not really 'exceptional' (certain aggregators might be expected to exceed min size somewhat often). I thought about expense of generating Exception and was thinking of disabling stacktrace creation in `MemoryExceededException ` class , but returning a value would do the job as well. > any dynamically growable aggregator that has to grow should choose its min size in order to avoid creating too many ByteBuffers. min size would be controlled by aggregator implementor and I would expect them to have default values but let it also be sent as part of XXXAggregatorFactory json spec to provide full control to user because right min size may need to be fine tuned for specific dataset/queries/indexing
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
