jon-wei commented on a change in pull request #8107: Add CliIndexer process 
type and initial task runner implementation
URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r307947994
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/initialization/ServerConfig.java
 ##########
 @@ -34,12 +34,45 @@
  */
 public class ServerConfig
 {
-
   public static final int DEFAULT_GZIP_INFLATE_BUFFER_SIZE = 4096;
 
+  public ServerConfig(
 
 Review comment:
   I'm not sure on the exact details of what ObjectMapper does to deserialize 
with those constructors, but I added a new `ServerConfigSerdeTest` that checks 
this behavior

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to