[GitHub] [incubator-druid] mcbrewster opened a new pull request #8219: Web-Console: stop log from making request after dialog close, implement query manager

[GitBox]

mcbrewster opened a new pull request #8219: Web-Console: stop log from making 
request after dialog close, implement query manager
URL: https://github.com/apache/incubator-druid/pull/8219
 
 
   <img width="294" alt="Screen Shot 2019-08-01 at 10 18 58 AM" 
src="https://user-images.githubusercontent.com/37322608/62313908-b5a96a00-b446-11e9-9aa7-dc205a01f03a.png";>
   
   Previously when you close the show log dialog the Timeout would continue to 
make network requests to get a task log. This is no longer the case. 
Additionally queries were made without a query manager which prompted the 
memory leak error. A query manager has been implemented to stop this. 
   
   ### Description
   
   added tail-query manager and a showlog query manager that handle the network 
request and the timeout respectively. This should protect against memory leaks 
as well as be consistent with the way queries work across the console.
   
   Clear timeout in the component will unmount lifecycle hook. 
   #### Fixed the bug ...
   #### Renamed the class ...
   #### Added a forbidden-apis entry ...
   
   This PR has:
   - [x ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   <img width="294" alt="Screen Shot 2019-08-01 at 10 18 58 AM" 
src="https://user-images.githubusercontent.com/37322608/62313903-b2ae7980-b446-11e9-9225-79bf4b0b7014.png";>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org