ccaominh commented on a change in pull request #8223: Add IPv4 SQL functions
URL: https://github.com/apache/incubator-druid/pull/8223#discussion_r309929387
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidOperatorTable.java
##########
@@ -243,6 +253,8 @@
.add(new MultiValueStringPrependOperatorConversion())
.add(new MultiValueStringSliceOperatorConversion())
.add(new StringToMultiValueStringOperatorConversion())
+ //
Review comment:
Yeah, I can add that heading though it's a bit redundant with the named
constant. I mostly wanted to separate from the multi-value string operators. I
can make things consistent by either adding each of the IPv4 operators here or
by creating new named constants for each of the groups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
