egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r310182002
########## File path: server/src/main/java/org/apache/druid/server/coordinator/duty/CoordinatorDuty.java ########## @@ -17,26 +17,25 @@ * under the License. */ -package org.apache.druid.server.coordinator.helper; +package org.apache.druid.server.coordinator.duty; +import org.apache.druid.server.coordinator.DruidCoordinator; import org.apache.druid.server.coordinator.DruidCoordinatorRuntimeParams; import javax.annotation.Nullable; /** * */ -public interface DruidCoordinatorHelper +public interface CoordinatorDuty Review comment: I'm confused again. I just did a spot check and it gave me a bunch of different results which don't look like yours:  If you're serious, I wouldn't like to argue on that level of abstraction anymore. I see this change as redundant, that's my professional opinion, you can ignore it, of course. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
