gianm commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310320526
########## File path: processing/src/main/java/org/apache/druid/segment/filter/ColumnComparisonFilter.java ########## @@ -141,12 +147,25 @@ public boolean supportsBitmapIndex(BitmapIndexSelector selector) return false; } + @Nullable + @Override + public FilterTuning getManualTuning() + { + return manualFilterTuning; + } + @Override public boolean supportsSelectivityEstimation(ColumnSelector columnSelector, BitmapIndexSelector indexSelector) { return false; } + @Override + public Set<String> getRequiredColumns() + { + return dimensions.stream().map(dim -> dim.getDimension()).collect(Collectors.toSet()); Review comment: `map(DimensionSpec::getDimension)`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org