leventov commented on a change in pull request #8209: add mechanism to control 
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310704426
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/query/filter/ColumnComparisonDimFilter.java
 ##########
 @@ -114,10 +141,4 @@ public boolean equals(Object o)
         .collect(Collectors.toSet())
 
 Review comment:
   Please fix `Sets.newHashSet(...collect(...))`. I've also opened #8241 about 
fixing this generically.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to