gianm commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310885038
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/Filters.java
##########
@@ -651,4 +652,17 @@ private static void generateAllCombinations(
generateAllCombinations(result, andList.subList(1, andList.size()),
nonAndList);
}
}
+
+ public static boolean shouldUseIndex(Filter filter, BitmapIndexSelector
indexSelector, FilterTuning filterTuning)
Review comment:
Could use a bit of javadocs as to its purpose ("standard" implementation of
Filter.shouldUseIndex) and how it works (returns true if the filter supports
indexes and if all underlying columns match the thresholds in `filterTuning`).
Also that `filterTuning` is nullable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
