ccaominh commented on a change in pull request #6974: sql support for dynamic
parameters
URL: https://github.com/apache/incubator-druid/pull/6974#discussion_r311280898
##########
File path: sql/src/main/java/org/apache/druid/sql/SqlLifecycle.java
##########
@@ -231,16 +255,19 @@ public PlannerContext planAndAuthorize(final
HttpServletRequest req)
}
}
+ @VisibleForTesting
Review comment:
Nice addition of the annotation!
As a side note: This method only appears to be called in tests, so it makes
sense that we later refactor it out of this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
