clintropolis commented on a change in pull request #8209: add mechanism to
control filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r312215202
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/ColumnComparisonFilter.java
##########
@@ -148,9 +148,9 @@ public boolean supportsBitmapIndex(BitmapIndexSelector
selector)
}
@Override
- public boolean shouldUseIndex(BitmapIndexSelector bitmapIndexSelector)
+ public boolean shouldUseBitmapIndex(BitmapIndexSelector selector)
{
- return Filters.shouldUseIndex(this, bitmapIndexSelector, filterTuning);
+ return Filters.shouldUseBitmapIndex(this, selector, filterTuning);
Review comment:
agree, changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
