pjain1 commented on a change in pull request #7306: Reconcile terminology and
method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r315135615
##########
File path: web-console/old-console/index.html
##########
@@ -42,7 +42,7 @@
<a href="config.html">Configure Coordinator Parameters</a>
</div>
<div>
- <a href="enable.html">Enable/Disable Datasources</a>
+ <a href="use-data-source.html">Mark all segments in data sources as
used or unused</a>
Review comment:
I think we should keep `Datasource` text as it is for consistency reasons
with previous versions and documentation as conceptually I am used to think
datasource as a noun which represents something similar to what table
represents in database world. Also there are many places where `datasource` is
used as a single word in documentation and new unified console. For example -
https://druid.apache.org/docs/latest/design/index.html#datasources-and-segments
says `Druid data is stored in "datasources", which are similar to tables in a
traditional RDBMS.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
