ccaominh commented on a change in pull request #8350: Fix the shuffle with TLS enabled for parallel indexing; add an integration test; improve unit tests URL: https://github.com/apache/incubator-druid/pull/8350#discussion_r316840229
########## File path: core/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java ########## @@ -22,23 +22,15 @@ import org.jboss.netty.handler.codec.http.HttpResponse; import org.jboss.netty.handler.codec.http.HttpResponseStatus; -/** - */ -public class FullResponseHolder +public abstract class FullResponseHolder<T> Review comment: If a `ReponseHolder` interface was added, would that simplify any of the changes? I think if that had already been in place, many of the test modification you made may have not been needed, for example. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
