jihoonson commented on a change in pull request #8297: Fix wrong partitionsSpec 
type names in the document
URL: https://github.com/apache/incubator-druid/pull/8297#discussion_r316930135
 
 

 ##########
 File path: docs/content/ingestion/native_tasks.md
 ##########
 @@ -599,9 +602,13 @@ The tuningConfig is optional and default parameters will 
be used if no tuningCon
 |property|description|default|required?|
 |--------|-----------|-------|---------|
 |type|The task type, this should always be "index".|none|yes|
+|maxRowsPerSegment|Deprecated. Use `partitionsSpec` instead. Used in sharding. 
Determines how many rows are in each segment.|5000000|no|
 |maxRowsInMemory|Used in determining when intermediate persists to disk should 
occur. Normally user does not need to set this, but depending on the nature of 
data, if rows are short in terms of bytes, user may not want to store a million 
rows in memory and this value should be set.|1000000|no|
 |maxBytesInMemory|Used in determining when intermediate persists to disk 
should occur. Normally this is computed internally and user does not need to 
set it. This value represents number of bytes to aggregate in heap memory 
before persisting. This is based on a rough estimate of memory usage and not 
actual usage. The maximum heap memory usage for indexing is maxBytesInMemory * 
(2 + maxPendingPersists)|1/6 of max JVM memory|no|
-|partitionsSpec|Defines how to partition the segments in a timeChunk, see 
[PartitionsSpec](#partitionsspec)|`dynamic` if `forceGuaranteedRollup` = false, 
`hashed` if `forceGuaranteedRollup` = true|no|
+|maxTotalRows|Deprecated. Use `partitionsSpec` instead. Total number of rows 
in segments waiting for being pushed. Used in determining when intermediate 
pushing should occur.|20000000|no|
+|numShards|Deprecated. Use `partitionsSpec` instead. Directly specify the 
number of shards to create. If this is specified and 'intervals' is specified 
in the granularitySpec, the index task can skip the determine 
intervals/partitions pass through the data. numShards cannot be specified if 
maxRowsPerSegment is set.|null|no|
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to