leventov commented on a change in pull request #8394: 8156 :
StructuralSearchInspection, Prohibit check on Thread.getState()
URL: https://github.com/apache/incubator-druid/pull/8394#discussion_r317504407
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -311,10 +311,15 @@
<constraint name="k" within="" contains="" />
<constraint name="v" within="" contains="" />
</searchConfiguration>
- <searchConfiguration name="Prohibit Thread.getState() != TERMINATED
antipattern"
text="while($k$.getDelayedCloseExecutor().getState()!=Thread.State.$k1$){Thread.sleep($k2$)}"
recursive="true" caseInsensitive="true" type="JAVA">
- <constraint name="k" within="" contains="" />
- <constraint name="k1" within="" contains="" />
- <constraint name="k2" within="" contains="" />
+ <searchConfiguration name="Prohibit Thread.getState() != TERMINATED
antipattern"
text="while($t$.getState()!=Thread.State.$state$){Thread.sleep($t1$)}"
recursive="true" caseInsensitive="true" type="JAVA">
+ <constraint name="t" within="" contains="" />
+ <constraint name="state" within="" contains="" />
+ <constraint name="t1" within="" contains="" />
+ </searchConfiguration>
+ <searchConfiguration name="Prohibit Thread.getState() == TERMINATED
antipattern"
text="while($t$.getState()==Thread.State.$state$){Thread.sleep($t1$)}"
recursive="true" caseInsensitive="true" type="JAVA">
Review comment:
And here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
