leventov commented on a change in pull request #8272: Support incremental load
in Druid lookups
URL: https://github.com/apache/incubator-druid/pull/8272#discussion_r320226707
##########
File path:
extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/CacheScheduler.java
##########
@@ -386,12 +398,14 @@ public String toString()
final String entryId;
final CacheHandler cacheHandler;
final String version;
+ boolean incremental;
Review comment:
The logic of this class is already too convoluted. Please add at least some
comments explaining what is going on here. For example, it's very non-trivial
to see why `VersionedCache.close()` shouldn't consider `incremental`, but the
handling in `generateCache()` should be different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
