clintropolis commented on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-537802979 >I'm strongly in favor of making the new behavior opt-out rather than opt-in, and removing the old behavior after a few versions of Druid released. We don't need more configurations here, parallel merges should be good for everybody. @leventov I totally agree that this shouldn't have much of any config. Most of the config that exists in the PR currently is for my testing. I _was_ planning to make it opt-in initially though because I wasn't sure I would get sufficient testing in to be confident enough to make it the default yet, but I went ahead made the change in this branch and have been running all queries (except scan) on a test cluster for a couple days now and so far so good. I'm a bit worried about the dumb, greedy, level of parallelism chooser currently in place, I need to perform additional stress testing to try and find where things fall apart. I think my goal here is to not be significantly _worse_ than the current behavior under load, though measuring this sounds .. difficult, so I will see what I can do.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
