jihoonson commented on a change in pull request #8573: Stateful auto compaction
URL: https://github.com/apache/incubator-druid/pull/8573#discussion_r333777328
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/coordinator/helper/NewestSegmentFirstIterator.java
 ##########
 @@ -229,15 +236,58 @@ public boolean hasNext()
     }
   }
 
+  private static boolean needsCompaction(DataSourceCompactionConfig config, 
SegmentsToCompact candidates)
 
 Review comment:
   `DruidCoordinatorSegmentCompactorTest` verifies the behavior of 
`DruidCoordinatorSegmentCompactor`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to