clintropolis opened a new pull request #8723: fix indexer segment announcement when used with http inventory view URL: https://github.com/apache/incubator-druid/pull/8723 Fixes #8710. ### Description This PR modifies `CliIndexer` to announce itself as a `dataNodeService` in addition to `lookupNodeService` and `workerNodeService`, so that it functions correctly with `druid.serverview.type=http`. This involved both adding the service class to the `DiscoverySideEffectsProvider` announcer binding, as well as adding a dummy `null` provider for `SegmentLoadDropHandler` to make `SegmentListerResource` (which actually provides the segment "announcement" functionality in http inventory management) happy instead of explodey. MiddleManager nodes do not have this problem because tasks that are not running on an Indexer [perform this announcement themselves](https://github.com/apache/incubator-druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java#L394), since it is per task. Indexers rightfully suppress this per task announcement which would be super redundant, but were lacking this part of the announcement happening anywhere at an outer level. I could not determine good way to add automated tests for this at this time. I believe integration tests would probably be the most appropriate way, but adding additional containers does not seem like the correct or a scalable approach. Ideally I think the integration tests would probably run in some sort of configuration matrix so we could try out the variations to make sure everything is cool, but we also maybe have too much variation to make this worth the time. In this specific case, maybe continuing to push to phase out reliance on Zookeeper would result in test coverage, assuming this configuration became the default, though I think we still have a lot of qualification to do before that change can be made. I did at least ensure things worked correctly on a tiny laptop cluster once the fix was in place. <hr> This PR has: - [x] been self-reviewed. - [x] been tested in a test Druid cluster.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
