himanshug commented on a change in pull request #8656: Message rejection
absolute date
URL: https://github.com/apache/incubator-druid/pull/8656#discussion_r338309318
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorIOConfig.java
##########
@@ -62,9 +67,19 @@ public SeekableStreamSupervisorIOConfig(
this.lateMessageRejectionPeriod = lateMessageRejectionPeriod == null
? Optional.absent()
:
Optional.of(lateMessageRejectionPeriod.toStandardDuration());
+ this.lateMessageRejectionStartDateTime = lateMessageRejectionStartDateTime
== null
+ ? Optional.absent()
+ :
Optional.of(lateMessageRejectionStartDateTime);
this.earlyMessageRejectionPeriod = earlyMessageRejectionPeriod == null
? Optional.absent()
:
Optional.of(earlyMessageRejectionPeriod.toStandardDuration());
+
+ if (this.lateMessageRejectionPeriod.isPresent()
+ && this.lateMessageRejectionStartDateTime.isPresent()) {
+ throw new JsonMappingException("SeekableStreamSupervisorIOConfig does
not support "
Review comment:
for validation errors, we don't use checked exceptions but .. `IAE` would be
more appropriate. please remove the `throws Exception` etc from constructor of
other classes where it was added due to this.
```suggestion
throw new IAE("SeekableStreamSupervisorIOConfig does not support "
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
